Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination to protocol history table #205

Closed
wants to merge 3 commits into from

Conversation

rozanagy
Copy link
Contributor

@rozanagy rozanagy commented Oct 30, 2024

This pull request introduces pagination to the ProtocolHistoryTable component in protocol-history-table.tsx. The most important changes include adding state management for pagination, updating the component to display a subset of items per page, and adding navigation buttons for page control.
Screenshot 2024-10-30 at 14 33 59

@rozanagy rozanagy requested a review from Polybius93 October 30, 2024 10:52
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for dev-mint-dlc-link failed.

Name Link
🔨 Latest commit 8457c70
🔍 Latest deploy log https://app.netlify.com/sites/dev-mint-dlc-link/deploys/672b740ce97a35000801d3fc

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for test-mint-dlc-link failed.

Name Link
🔨 Latest commit 8457c70
🔍 Latest deploy log https://app.netlify.com/sites/test-mint-dlc-link/deploys/672b740caacb1b0008829da1

Copy link
Collaborator

@Polybius93 Polybius93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally the logic looks good, see if you could simplify some parts of it. UI-wise, can you please modify the looks of the buttons so it would fit into the overall design, and maybe center them in the VStack? Thank you!

Copy link
Collaborator

@Polybius93 Polybius93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good! There is some conflict and commit error, but otherwise approved!

@Polybius93 Polybius93 closed this Nov 7, 2024
@Polybius93 Polybius93 deleted the feat/add-pagination-to-protocol-history-table branch November 7, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants